fixed issues 1, 3, 5#8
Open
chensteven wants to merge 1 commit into
Open
Conversation
This was referenced Nov 7, 2018
vincenthang
requested changes
Nov 8, 2018
There was a problem hiding this comment.
Couple of issues introduced:
-
the Confirm button on the SMS authentication screen doesn't work for me. (given ERROR: Attempt Limit Exceeded in console; and cannot exit out of the authentication screen)
-
if you exit the app on the SMS authentication screen, the phone number becomes taken. (should be still available)
And an enhancement:
- we should keep the email just for reference (no verification), it's good for early-stage growth with email marketing.
TLDR: #1, and #3 solved; but issues above were introduced (I couldn't sign up).
Contributor
Author
Enhancement: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please confirm issue #1, #3, #5 is fixed. If so, merge pull request and I will close the Issues.